Re: [PATCH 5/7] tag: handle `pager.tag`-configuration within the builtin
- Date: Tue, 11 Jul 2017 06:38:41 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH 5/7] tag: handle `pager.tag`-configuration within the builtin
On Mon, Jul 10, 2017 at 11:55:18PM +0200, Martin Ågren wrote:
> Use the mechanisms introduced in two earlier patches to ignore
> `pager.tag` in git.c and let the `git tag` builtin handle it on its own.
> This is in preparation for the next patch, where we will want to handle
> slightly different configuration variables depending on which options
> are used with `git tag`. For this reason, place the call to
> setup_auto_pager() after the options have been parsed.
> No functional change is intended. That said, there is a window between
> where the pager is started before and after this patch, and if an error
> occurs within this window, as of this patch the error message might not
> be paged where it would have been paged before. Since
> operation-parsing has to happen inside this window, a difference can be
> seen with, e.g., `git -c pager.tag="echo pager is used" tag
> --unknown-option`. This change in paging-behavior should be acceptable
> since it only affects erroneous usages.
Thanks for carefully thinking through the details. I agree that it's an
acceptable change of behavior.