Re: [PATCH] apply: use strcmp(3) for comparing strings in gitdiff_verify_name()
- Date: Sat, 8 Jul 2017 13:52:11 +0200
- From: René Scharfe <l.s.r@xxxxxx>
- Subject: Re: [PATCH] apply: use strcmp(3) for comparing strings in gitdiff_verify_name()
Am 08.07.2017 um 13:08 schrieb Ramsay Jones:
On 08/07/17 09:58, René Scharfe wrote:
Avoid running over the end of another -- a C string whose length we
don't know -- by using strcmp(3) instead of memcmp(3) for comparing it
with another C string.
I had to read this twice, along with the patch text, before this
made any sense. ;-) The missing information being that 'another'
was the name of the string variable that we were potentially
'running over the end of'.
Yeah, sorry, encasing that unusual variable name in quotes would
probably have helped.