Web lists-archives.com

Re: [PATCH 00/23] Prepare to separate out a packed_ref_store




On Thu, May 18, 2017 at 07:14:38PM +0200, Johannes Sixt wrote:

> Am 17.05.2017 um 14:05 schrieb Michael Haggerty:
> > This patch series is the next leg on a journey towards reading
> > `packed-refs` using `mmap()`, the most interesting aspect of which is
> > that we will often be able to avoid having to read the whole
> > `packed-refs` file if we only need a subset of references.
> 
> Which features of mmap() are you going to use? We have only MAP_PRIVATE on
> Windows. We do emulate PROT_WRITE (without PROT_READ), but I don't think
> that code is exercised anywhere. See also compat/win32mmap.c.

It's just on the reading side, so it should be the same as the mmaps we
do for reading packfiles, the index, etc. You can see the actual call in
the upcoming series that Michael linked earlier:

  https://github.com/mhagger/git/commit/d22420b5f3e967d24aba019a0916a5a93ab00e03

-Peff