Web lists-archives.com

Re: [PATCH 00/23] Prepare to separate out a packed_ref_store

On Wed, May 17, 2017 at 6:42 AM, Jeff King <peff@xxxxxxxx> wrote:
> On Wed, May 17, 2017 at 02:05:23PM +0200, Michael Haggerty wrote:
>> This patch series is the next leg on a journey towards reading
>> `packed-refs` using `mmap()`, the most interesting aspect of which is
>> that we will often be able to avoid having to read the whole
>> `packed-refs` file if we only need a subset of references.
>> The first leg of the journey was separating out the reference cache
>> into a separate module [1]. That branch is already merged to master.
>> This patch series prepares the ground for separating out a
>> `packed_ref_store`, but doesn't yet take that step. (As you can see,
>> it's a long enough patch series already!) It's kind of a grab bag of
>> cleanup patches plus work to decouple the packed-refs handling code
>> from the rest of `files_ref_store`. Some highlights:
> I dropped a few minor comments in individual patches, but it all looks
> good to me up through patch 22. Your description in patch 23 makes
> sense, but I was too frazzled by the end to carefully review the code
> itself for that patch. I'll try to come back to it later.

Same here.