Web lists-archives.com

Re: [PATCH 14/19] diff.c: convert word diffing to use emit_line_*




On Mon, May 15, 2017 at 3:40 PM, Jonathan Tan <jonathantanmy@xxxxxxxxxx> wrote:
>
> I suspect that this will need to be refactored more thoroughly. Here, for
> example, emit_line (which prints the prefix) is printed nearly
> unconditionally, whereas in the original version, "fputs(line_prefix, fp)"
> is only printed when "print" is true.

Yes, manual testing confirms this is the case. Maybe I should to add a test
for "git diff --word-diff --line-prefix"

Thanks,
Stefan