Re: [PATCH] fixup! log: add exhaustive tests for pattern style options & config
- Date: Mon, 15 May 2017 11:18:17 +0900
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH] fixup! log: add exhaustive tests for pattern style options & config
Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > Thanks for the hotfix. I'll fix this in my v2, but do it differently > in such a way that I can still run these tests on windows. > > I.e. the actual test here just needs these odd characters in the > commit message. It's just an unintended implementation detail of > test_commit that a tag is being created. My knee-jerk reaction matched Dscho's, but grep is about contents, and we should be able to test this if we used a sensible tagnames or didn't use any. Glad to see somebody can step back and think ;-)
- Follow-Ups:
- Re: [PATCH] fixup! log: add exhaustive tests for pattern style options & config
- From: Johannes Schindelin
- Re: [PATCH] fixup! log: add exhaustive tests for pattern style options & config
- References:
- [PATCH] fixup! log: add exhaustive tests for pattern style options & config
- From: Johannes Schindelin
- Re: [PATCH] fixup! log: add exhaustive tests for pattern style options & config
- From: Ævar Arnfjörð Bjarmason
- [PATCH] fixup! log: add exhaustive tests for pattern style options & config
- Prev by Date: Re: [PATCH] interpret-trailers: obey scissors lines
- Next by Date: Re: [PATCH v4 1/3] usability: don't ask questions if no reply is required
- Previous by thread: Re: [PATCH] fixup! log: add exhaustive tests for pattern style options & config
- Next by thread: Re: [PATCH] fixup! log: add exhaustive tests for pattern style options & config
- Index(es):