Re: [PATCH] fixup! log: add exhaustive tests for pattern style options & config
- Date: Sat, 13 May 2017 15:22:30 +0200
- From: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
- Subject: Re: [PATCH] fixup! log: add exhaustive tests for pattern style options & config
On Sat, May 13, 2017 at 1:44 AM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
> Johannes Schindelin wrote:
>> On Windows, `(1|2)` is not a valid file name, and therefore the tag
>> cannot be created as expected by the new test.
>> So simply skip this test on Windows.
>> Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
> Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
> I wouldn't be surprised if there are filesystems used places other
> than MINGW that also can't handle this test. Isn't this what some
> tests use a FUNNYNAMES prerequisite for?
> In this example, it's the pipe that's not allowed, not the
> parenthesis, right? (At least I have some memories of naming files
> with some parentheses.) Would something like
> test PIPE_IN_FILENAME '
> >"a|b" &&
> test -f "a|b"
It would, but as indicated upthread I'll just amend this so the odd
tag/filename won't be needed, since the test doesn't actually use
(B.t.w. I meant "[odd looking] tag or file" in my last E-Mail in this
thread, not just "[odd looking tag]")>