Re: [PATCH] fixup! log: add exhaustive tests for pattern style options & config
- Date: Sat, 13 May 2017 15:20:17 +0200
- From: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
- Subject: Re: [PATCH] fixup! log: add exhaustive tests for pattern style options & config
On Fri, May 12, 2017 at 12:50 PM, Johannes Schindelin
> On Windows, `(1|2)` is not a valid file name, and therefore the tag
> cannot be created as expected by the new test.
> So simply skip this test on Windows.
Thanks for the hotfix. I'll fix this in my v2, but do it differently
in such a way that I can still run these tests on windows.
I.e. the actual test here just needs these odd characters in the
commit message. It's just an unintended implementation detail of
test_commit that a tag is being created.
> Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
> Published-As: https://github.com/dscho/git/releases/tag/exhaustive-grep-tests-fixup-v1
> Fetch-It-Via: git fetch https://github.com/dscho/git exhaustive-grep-tests-fixup-v1
> t/t4202-log.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/t/t4202-log.sh b/t/t4202-log.sh
> index 36321f19061..6f108e99b7b 100755
> --- a/t/t4202-log.sh
> +++ b/t/t4202-log.sh
> @@ -296,7 +296,7 @@ test_expect_success 'log with grep.patternType configuration and command line' '
> test_cmp expect actual
> -test_expect_success 'log with various grep.patternType configurations & command-lines' '
> +test_expect_success !MINGW 'log with various grep.patternType configurations & command-lines' '
> git init pattern-type &&
> cd pattern-type &&
> base-commit: 3760a479060228867a31eed443334b30124465b9