Web lists-archives.com

Re: [PATCH v1] diffcore-rename: speed up register_rename_src




Jeff King <peff@xxxxxxxx> writes:

>   - this patch probably adds "unsorted tree" to the list of breakages
>     that would cause us to skip rename detection. I don't know if that's
>     actually possible in practice (i.e., do we end up sorting the
>     diffq elsewhere anyway?). I also wondered if it might run afoul of
>     diffcore_order(), but that is applied after rename detection, so
>     we're OK.

One of the frontends (I think it was diff-index) couldn't generate
sorted output (which is input to diffcore-* machinery) but I think
diffq is sorted before getting passed to the diffcore-* machinery in
that codepath, so we should be also OK on that front.