Re: What's cooking in git.git (Apr 2017, #04; Wed, 19)
- Date: Thu, 20 Apr 2017 16:18:36 -0700
- From: Brandon Williams <bmwill@xxxxxxxxxx>
- Subject: Re: What's cooking in git.git (Apr 2017, #04; Wed, 19)
On 04/20, Brandon Williams wrote:
> On 04/20, Johannes Schindelin wrote:
> > Hi Lars & Junio,
> > On Thu, 20 Apr 2017, Lars Schneider wrote:
> > > > * bw/forking-and-threading (2017-04-19) 11 commits
> > > > - run-command: block signals between fork and execve
> > > > - run-command: add note about forking and threading
> > > > - run-command: handle dup2 and close errors in child
> > > > - run-command: eliminate calls to error handling functions in child
> > > > - run-command: don't die in child when duping /dev/null
> > > > - run-command: prepare child environment before forking
> > > > - string-list: add string_list_remove function
> > > > - run-command: use the async-signal-safe execv instead of execvp
> > > > - run-command: prepare command before forking
> > > > - t0061: run_command executes scripts without a #! line
I just double checked what differences existed between what I have
locally and what is queued at bw/forking-and-threading and it looks like
the changes (adding the !MINGW) to just this one patch were missed,
while the rest of them were picked up. Just and fyi.
> > > > - t5550: use write_script to generate post-update hook
> > > >
> > > > The "run-command" APIimplementation has been made more robust
> > > > against dead-locking in a threaded environment.
> > > >
> > > > Will merge to 'next'.
> > >
> > > There might be a problem on Windows with this (that's just a hunch, i can't test this right now):
> > > https://travis-ci.org/git/git/jobs/223830474
> > Thanks for keeping track of Travis' failure reports. From what I see, the
> > latest iteration (which does not seem to have made it to `pu` yet) has the
> > !MINGW prerequisite which should fix the issue. Hopefully my suggested
> > addition to the commit message will make it into the commit history, too.
> Thanks for catching this. And as you pointed out the latest reroll
> should fix the issue.
> > Ciao,
> > Dscho
> Brandon Williams