Re: [PATCH] test-lib: abort when can't remove trash directory
- Date: Thu, 20 Apr 2017 15:06:54 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH] test-lib: abort when can't remove trash directory
On Thu, Apr 20, 2017 at 06:52:30PM +0200, SZEDER Gábor wrote:
> We had two similar bugs in the tests sporadically triggering error
> messages during the removal of the trash directory, see commits
> bb05510e5 (t5510: run auto-gc in the foreground, 2016-05-01) and
> ef09036cf (t6500: wait for detached auto gc at the end of the test
> script, 2017-04-13). The test script succeeded nonetheless, because
> these errors are ignored during housekeeping in 'test_done'.
> However, such an error is a sign that something is fishy in the test
> script. Print an error message and abort the test script when the
> trash directory can't be removed successfully or is already removed,
> because that's unexpected and we woud prefer somebody notice and
> figure out why.
> Signed-off-by: SZEDER Gábor <szeder.dev@xxxxxxxxx>
I think this is a good idea, and the patch itself looks good. Thanks.