Web lists-archives.com

Re: [PATCH v5 02/11] t0061: run_command executes scripts without a #! line




Hi Brandon,

On Wed, 19 Apr 2017, Brandon Williams wrote:

> On 04/19, Johannes Sixt wrote:
> > Am 19.04.2017 um 07:43 schrieb Johannes Sixt:
> > >Am 19.04.2017 um 01:17 schrieb Brandon Williams:
> > >>Add a test to 't0061-run-command.sh' to ensure that run_command can
> > >>continue to execute scripts which don't include a '#!' line.
> > >
> > >Why is this necessary? I am pretty certain that our emulation layer
> > >on Windows can only run scripts with a shbang line.
> 
> Out of curiosity how did you have t5550 passing on windows then?

This is the reason:

	1..0 # SKIP no web server found at '/usr/sbin/apache2'

As predicted by Hannes, your new test fails miserably on Windows:

	https://travis-ci.org/git/git/jobs/223830474#L2656-L2674

Ciao,
Dscho