Re: [PATCH] t1400: use consistent style for test_expect_success calls
- Date: Sun, 16 Apr 2017 00:28:10 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH] t1400: use consistent style for test_expect_success calls
On Sat, Apr 15, 2017 at 10:31:02PM -0400, Kyle Meyer wrote:
> Structure calls as
> test_expect_success 'description' '
> Use double quotes for the description if it requires parameter
> expansion or contains a single quote.
> Signed-off-by: Kyle Meyer <kyle@xxxxxxxxxx>
Looks good to me.
> -test_expect_success \
> - 'creating initial files' \
> - 'test_when_finished rm -f M &&
> - echo TEST >F &&
> - git add F &&
> - GIT_AUTHOR_DATE="2005-05-26 23:30" \
> - GIT_COMMITTER_DATE="2005-05-26 23:30" git commit -m add -a &&
Not even sure what's going on with the indentation here in the original.
I don't see any reason this "git add" should start an indented block.
This and the other whitespace fixes all look improvements to me.