Re: [PATCHv3] rebase: pass --[no-]signoff option to git am
- Date: Sat, 15 Apr 2017 03:03:40 -0700
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCHv3] rebase: pass --[no-]signoff option to git am
Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx> writes:
>> We need new tests for "git rebase --signoff" that makes sure this
>> works as expected and only when it should.
> Would the norm in this case be to introduce the test in the same
> commit, or in a previous commit (as in: this is the feature we want to
> implement, it obviously doesn't work now, but the next commit will fix
> that), or in a subsequent one?
For a new feature (especially with this small implementation), it is
best to have the test in the same commit.
We often use the "start with expect_failure, update the code while
flipping _failure to _success" pattern but that is primarily
suitable for bugfixes.