Web lists-archives.com

Re: [PATCH v3 06/10] run-command: don't die in child when duping /dev/null




On 04/14, Eric Wong wrote:
> Brandon Williams <bmwill@xxxxxxxxxx> wrote:
> > +	if (cmd->no_stdin || cmd->no_stdout || cmd->no_stderr) {
> > +		null_fd = open("/dev/null", O_RDWR | O_CLOEXEC | O_NONBLOCK);
> 
> O_NONBLOCK?  This was in my original patch, too :x
> Wow, I wonder what I was smoking that day...

And I apparently wasn't thinking enough to catch that!  I'll fix that.

-- 
Brandon Williams