Re: [PATCH] xgethostname: handle long hostnames
- Date: Thu, 13 Apr 2017 17:23:41 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH] xgethostname: handle long hostnames
On Thu, Apr 13, 2017 at 03:23:35PM -0400, David Turner wrote:
> If the full hostname doesn't fit in the buffer supplied to
> gethostname, POSIX does not specify whether the buffer will be
Wow, TIL. What an utterly terrible and error-prone interface (I always
just assumed we'd get ENAMETOOLONG, which is what glibc does).
> so to be safe, we should do it ourselves. Introduce
> new function, xgethostname, which ensures that there is always a \0
> at the end of the buffer.
Your patch looks good to me.