Re: [PATCH v2 1/6] t5550: use write_script to generate post-update hook
- Date: Thu, 13 Apr 2017 13:43:58 -0700
- From: Jonathan Nieder <jrnieder@xxxxxxxxx>
- Subject: Re: [PATCH v2 1/6] t5550: use write_script to generate post-update hook
Brandon Williams wrote:
> The post-update hooks created in t5550-http-fetch-dumb.sh is missing the
> "!#/bin/sh" line which can cause issues with portability. Instead
> create the hook using the 'write_script' function which includes the
> proper "#!" line.
> Signed-off-by: Brandon Williams <bmwill@xxxxxxxxxx>
> t/t5550-http-fetch-dumb.sh | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
This would allow later patches to regress a previously supported
I agree that it's silly to test that behavior as a side-effect of this
unrelated test, but I don't think we want to lose the test coverage.
Thanks for tracking this down and hope that helps,