Re: [PATCH v2 4/6] run-command: don't die in child when duping /dev/null
- Date: Thu, 13 Apr 2017 19:29:28 +0000
- From: Eric Wong <e@xxxxxxxxx>
- Subject: Re: [PATCH v2 4/6] run-command: don't die in child when duping /dev/null
Brandon Williams <bmwill@xxxxxxxxxx> wrote:
> @@ -487,7 +483,7 @@ int start_command(struct child_process *cmd)
> atexit(notify_parent);
>
> if (cmd->no_stdin)
> - dup_devnull(0);
> + dup2(null_fd, 0);
I prefer we keep error checking for dup2 failures,
and also add more error checking for unchecked dup2 calls.
Can be a separate patch, I suppose.
Ditto for other dup2 changes
> @@ -558,6 +554,8 @@ int start_command(struct child_process *cmd)
> }
> close(notify_pipe[0]);
>
> + if (null_fd > 0)
> + close(null_fd);
I would prefer:
if (null_fd >= 0)
here, even if we currently do not release stdin.
> argv_array_clear(&argv);
> free(childenv);