Re: [PATCH v6] http.postbuffer: allow full range of ssize_t values
- Date: Tue, 11 Apr 2017 11:27:40 -0700
- From: Jonathan Nieder <jrnieder@xxxxxxxxx>
- Subject: Re: [PATCH v6] http.postbuffer: allow full range of ssize_t values
David Turner wrote:
> Unfortunately, in order to push some large repos where a server does
> not support chunked encoding, the http postbuffer must sometimes
> exceed two gigabytes. On a 64-bit system, this is OK: we just malloc
> a larger buffer.
> This means that we need to use CURLOPT_POSTFIELDSIZE_LARGE to set the
> buffer size.
> Signed-off-by: David Turner <dturner@xxxxxxxxxxxx>
> cache.h | 1 +
> config.c | 17 +++++++++++++++++
> http.c | 6 ++++--
> http.h | 2 +-
> remote-curl.c | 12 +++++++++---
> 5 files changed, 32 insertions(+), 6 deletions(-)
The only unresolved issue was whether we can count on curl being new
enough for CURLOPT_POSTFIELDSIZE_LARGE to be present. I say
"unresolved" but it is resolved in my mind since git doesn't build and
pass tests with such old versions of curl --- what's unresolved is
formalizing what the oldest curl version is that we want to support.
And that doesn't need to hold this patch hostage.
So for what it's worth,
Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>