Re: [PATCH 06/12] log: add -P as a synonym for --perl-regexp
- Date: Tue, 11 Apr 2017 06:26:13 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH 06/12] log: add -P as a synonym for --perl-regexp
On Sat, Apr 08, 2017 at 01:25:00PM +0000, Ævar Arnfjörð Bjarmason wrote:
> Add a short -P option as a synonym for the longer --perl-regexp, for
> consistency with the options the corresponding grep invocations
> This was intentionally omitted in commit 727b6fc3ed ("log --grep:
> accept --basic-regexp and --perl-regexp", 2012-10-03) for unspecified
> future use.
> Since nothing has come along in over 4 1/2 years that's wanted to use
> it, it's more valuable to make it consistent with "grep" than to keep
> it open for future use, and to avoid the confusion of -P meaning
> different things for grep & log, as is the case with the -G option.
Like Junio, the "well, nothing else has come along" triggered my
initial reflexes. But I think the consistency argument you make here is
a good one. The "-P" option is tainted whether we do this or not.