Re: [PATCH 0/2] Re-integrate sha1dc
On Thu, Mar 16, 2017 at 3:04 PM, Jeff King <peff@xxxxxxxx> wrote:
> There are a few things I think are worth changing. The die() message
> should mention the sha1 we computed. That will be a big help if an old
> version of git tries to unknowingly push a colliding object to a newer
> version. The user will see "collision on sha1 1234.." which gives them a
> starting point to figure out where they got the bad object from.
> And to make that work, we have to disable the safe_hash feature (which
> intentionally corrupts a colliding sha1). We _could_ rip it out
> entirely, but since it only kicks in when we see a collision, I doubt
> it's impacting anything.
> I also updated the timings in my commit message, and added a basic test.
No complaints about your version.