Re: [PATCH] add--interactive: do not expand pathspecs with ls-files
- Date: Tue, 14 Mar 2017 12:31:56 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH] add--interactive: do not expand pathspecs with ls-files
On Tue, Mar 14, 2017 at 12:30:24PM -0400, Jeff King wrote:
> 2. Even when it does work, it's really slow. The pathspec
> code is not optimized for huge numbers of paths. Here's
> the same case without the ulimit:
> $ time git add -p drivers
> No changes.
> real 0m16.559s
> user 0m53.140s
> sys 0m0.220s
By the way, I wondered how we managed to consume more CPU than
wall-clock time. I think the answer is that diff-files does the pathspec
matching during the threaded preload stage.