Re: [PATCH v2] repack: Add option to preserve and prune old pack files
- Date: Sat, 11 Mar 2017 13:38:00 +0100
- From: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
- Subject: Re: [PATCH v2] repack: Add option to preserve and prune old pack files
On Fri, Mar 10, 2017 at 11:00 PM, James Melvin <jmelvin@xxxxxxxxxxxxxx> wrote:
> The new --preserve-and-prune option renames old pack files
> instead of deleting them after repacking and prunes previously
> preserved pack files.
I think some of this rationale...
> This option is designed to prevent stale file handle exceptions
> during git operations which can happen on users of NFS repos when
> repacking is done on them. The strategy is to preserve old pack files
> around until the next repack with the hopes that they will become
> unreferenced by then and not cause any exceptions to running processes
> when they are finally deleted (pruned).
...belongs in the actual docs, i.e. here:
> + Preserve old pack files by renaming them instead of deleting. Prune any
> + previously preserved pack files before preserving new ones.
This is a really obscure option with an obscure use-case, let's
explain that in the docs, and also mention NFS & what problems it
solves there, so someone having the same issue can find the solution