Re: [RFC][PATCH] index-pack: add testcases found using AFL
- Date: Fri, 10 Mar 2017 14:42:45 -0500
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [RFC][PATCH] index-pack: add testcases found using AFL
On Fri, Mar 10, 2017 at 08:34:45PM +0100, Vegard Nossum wrote:
> > That's something I guess, but I'm not enthused by the idea of just
> > dumping a bunch of binary test cases that nobody, not even the author,
> > understands.
> I understand your concern. This is how I see it:
> - 'make test' takes 1 second longer to run
> - 548K data added to git.git
My real concern is that this is the tip of the ice berg. So we increased
coverage in one program by a few percent. But wouldn't this procedure be
applicable to lots of _other_ parts of Git, too?
IOW, I'm worried about a day when we've added dozens or hundreds of
seconds to the test suite. Sure, we can quit adding at any time, but I
feel like it's easier to make a decision from the outset.
I'm tempted to say these should go into a different test-suite, or be
marked with a special flag or something. But then I guess nobody runs