Re: [PATCH 04/10] upload-pack: add partial (sparse) fetch
- Date: Thu, 9 Mar 2017 14:09:50 -0500
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH 04/10] upload-pack: add partial (sparse) fetch
On Thu, Mar 09, 2017 at 01:34:32PM -0500, Jeff Hostetler wrote:
> > > + partial = PKT-LINE("partial-by-size" SP magnitude) /
> > > + PKT-LINE("partial-special)
> > > +
> > I probably would have added this as a capability coming back from the
> > client, since it only makes sense to send once (the same way we ask for
> > other features like include-tag or ofs-delta). I guess it's six of one,
> > half a dozen of the other, though.
> True. I wanted the size argument. And later want to add
> a sparse-file. It seemed like they better belonged in a
> PKT-LINE than in the capability header.
Yeah, at some point we will run out of room in the capabilities
response. :) If the sparse information might be arbitrarily long (e.g.,
a list of pathspecs) then it probably is better for it to get split into
its own pktline (or even a series of pktlines).