Re: [PATCH] submodule--helper.c: remove duplicate code
- Date: Wed, 8 Mar 2017 15:34:27 -0800
- From: Stefan Beller <sbeller@xxxxxxxxxx>
- Subject: Re: [PATCH] submodule--helper.c: remove duplicate code
On Wed, Mar 8, 2017 at 3:24 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Stefan Beller <sbeller@xxxxxxxxxx> writes:
>>> should I start new thread for new patch series?
>> As you like.
>> As far as I understand, it is very easy for Junio to take a whole
>> (sub-)thread of patches and apply that and make a branch with
>> multiple commits out of it as he has tooling for that.
> Note that the world does not revolve around _me_. I was once asked
> for my preference and I responded and that is what you are recalling
> Others on the list do review and keeping it easy for them to is also
> important. What's _your_ preference?
I use gmail, that has a broken threading model
(it groups emails by subject lines; apparently not using any "in-reply-to"
relationship to build up a thread), so I do not care. At all.
I do not know about the preference of the next most likely
people to review submodule code, so I refrained from giving advice
depending on reviewer preference, but instead gave advice that would
ease your work as I recall.
After thinking about it further, you may want to make sure that the
topic is coherent and it is easy to discover all related emails in an
archive of the mailing list. https://public-inbox.org/git/
So in the cover letter you could link to the previous thread,
or just continue that thread by replying to an email that is appropriate for