Re: [PATCH] http: inform about alternates-as-redirects behavior
- Date: Sat, 4 Mar 2017 02:41:40 -0500
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH] http: inform about alternates-as-redirects behavior
On Sat, Mar 04, 2017 at 06:55:48AM +0000, Eric Wong wrote:
> Jeff King <peff@xxxxxxxx> wrote:
> > The warning itself:
> > > + warning("alternate disabled by http.followRedirects!=true: %s",
> > feels like it could use some whitespace around the "!=", but maybe
> > that's just me.
> Yeah, I kinda wanted to emulate the command-line syntax.
> Maybe rewording it a bit and showing how to enable it will
> make more sense:
> warning("alternate: %s", url);
> warning(" may be enabled by -c http.followRedirects=true");
I kind of hoped people would look at the documentation for
followRedirects before blindly enabling it. Though I guess the
documentation doesn't really explain the possible security implications,
so maybe it doesn't matter (and they're pretty subtle anyway).