Web lists-archives.com

Re: salsa.debian.org: merge requests and such




Hi,
On Tue, Nov 06, 2018 at 04:32:29PM +0100, Guillem Jover wrote:
> Hi!
> 
> On Tue, 2018-11-06 at 15:00:03 +0000, Matthew Vernon wrote:
> > Jacob Adams <tookmund@xxxxxxxxx> writes:
> > > The consensus seems to be that people should enable email
> > > notifications in salsa and open a bug when filing a merge request. 
> > >
> > > https://lists.debian.org/debian-devel/2018/08/msg00235.html
> > >
> > > https://lists.debian.org/debian-devel/2018/08/msg00259.html
> > 
> > Relatedly, what's the etiquette about commits to master? I recently
> > discovered that someone else had pushed a commit to the tip of master of
> > one of the packages I maintain (and not notified me); when I complained
> > I was told that emailing would be too much effort. Am I wrong to feel
> > that at least a MR is something I should have expected as a package
> > maintainer, not just commits to master?
> 
> Assuming that packages is under the Salsa Debian namespace, then I
> think that's what you (perhaps unknowingly :) signed up for when
> adding a repo there. See the Collab-maint sections in:
> 
>   <https://lists.debian.org/debian-devel-announce/2017/12/msg00003.html>
> 
> and
> 
>   <https://wiki.debian.org/Salsa/Doc#Collaborative_Maintenance:_.22Debian.22_group>
> 
> Because, I'm not sure what's the point of hosting a git repo, on a
> platform like gitlab with its trivial forking facilities, on a group
> with wide write permissions, if you don't want others to directly
> write to it? :)

Code review. Even if you can write directly it makes sense to allow
others (e.g. people uploading a package a lot) to have a look at the
changes first.

Cheers,
 -- Guido