Web lists-archives.com

Re: ssh-host-config: patch fix debug option + broken for me on Vista (non-domain)




On Jan 18 14:34, Shaddy Baddah wrote:
> Hi,
> 
> First please find attached a simple patch that fixes a problem I
> encountered running ssh-host-config with the --debug option.

Thanks, applied.

> And I'm sure the problem is that this well-intended change to the script
> fails on the assumption that LOGONSERVER is always populated. It isn't
> for me on Vista.
> 
> cygwin-service-installation-helper.sh:2884:      # This test succeeds on
> domain member machines only, not on DCs.
> cygwin-service-installation-helper.sh:2885:      if [
> "\\\\${COMPUTERNAME,,*}" != "${LOGONSERVER,,*}" \
> cygwin-service-installation-helper.sh:2886:        -a "${LOGONSERVER}" !=
> "\\\\MicrosoftAccount" ]
> cygwin-service-installation-helper.sh:2887:      then
> cygwin-service-installation-helper.sh:2888:     # Lowercase of USERDOMAIN
> cygwin-service-installation-helper.sh:2889:
> csih_PRIVILEGED_USERNAME="${COMPUTERNAME,,*}+${username}"
> cygwin-service-installation-helper.sh:2890:      fi
> cygwin-service-installation-helper.sh:2891:    fi
> 
> I fixed this by modifying the test to check LOGONSERVER is not empty:
> 
> if [ -n "${LOGONSERVER}" -a "\\\\...
> 
> Can this be fixed in the next release?

Sure, please provide a patch, I'll check it in and release a new csih
soonish.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: signature.asc
Description: PGP signature