Web lists-archives.com

Re: openssl-devel in openssh README




Greetings, Sorin Adrian Savu!

>> Greetings, Sorin Adrian Savu!
>>
>> > Hello!
>>
>> > I had to compile openssh recently, and the README for cygwin is
>> referencing
>> > openssl-devel package which is obsolete now. I spent some time trying to
>> > figure this out. Can you please update
>> >
>> https://github.com/openssh/openssh-portable/blob/85ceb0e64bff672558fc87958cd548f135c83cdd/contrib/cygwin/README#L80
>> > to
>> > mention libssl-devel instead ?
>>
>> > (I would do it, but I can't figure out how to submit a PR to that repo)
>>
>> Clone the repo on github to your account, create branch, make changes,
>> submit
>> a PR.


> As a generic approach, that would do, however openssh-portable has quite a
> few branches and being a security related package I was expecting some
> strict guidelines on how to submit patches (which I can't find).

If there's any guidelines, a bot would mail you once you submit a PR, like it
is so for Symfony subpackages. (When you file a PR against them, a bot comes
in, closes it and tells you to fu... erm, file it against main Symfony repo.)

> Anyhow, I see that all the patches start from master, so I will give it a
> try.

Why I suggest a branch is because somebody could more easily inspect it
locally, when there's doubts.
Checking out from remote's master is a little bit more convoluted and
error-prone, than from a branch.


-- 
With best regards,
Andrey Repin
Sunday, May 26, 2019 20:43:59

Sorry for my terrible english...


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple