Web lists-archives.com

Re: Re: Patch request to qt 5.9.4 (Re: [ANNOUNCEMENT] Qt 5.9.4)




--- yselkowitz wrote:
> On Mon, 2019-03-04 at 07:43 +0900, Tatsuro MATSUOKA wrote:
> > Dear Yaakov Selkowitz
> > 
> > I ask alpply a patch the below which enables to use qt terminal on gnuplot for Cygwin.
> > (cygQt5Network-5.dll is affected.)
> > 
> > --- a/qtbase-opensource-src-5.9.4/src/network/socket/qlocalsocket_unix.cpp
> > +++ b/qtbase-opensource-src-5.9.4/src/network/socket/qlocalsocket_unix.cpp
> > @@ -239,7 +239,7 @@ void QLocalSocket::connectToServer(OpenM
> >     }
> >     // create the socket
> > -    if (-1 == (d->connectingSocket = qt_safe_socket(PF_UNIX, SOCK_STREAM, 0, O_NONBLOCK))) {
> > +    if (-1 == (d->connectingSocket = qt_safe_socket(PF_UNIX, SOCK_STREAM, 0))) {
> >         d->errorOccurred(UnsupportedSocketOperationError,
> >                         QLatin1String("QLocalSocket::connectToServer"));
> >         return;
> > 
> 
> It seems we keep going in circles on this point.  If there is a bug in
> O_NONBLOCK, then please either narrow it down to an STC, or provide a
> patch to Cygwin.
> 
> --
> Yaakov
> 
> 
> 
I contacted with Enrico who tells me the patch that I have shown.

His reply is the below.

**********************************
Dear Tatsuro,

unfortunately I do not have an STC other than the evidence that the
above patch works for gnuplot. I have always had problems with O_NONBLOCK
on cygwin. For example, see
https://www.mail-archive.com/cygwin@xxxxxxxxxx/msg104221.html 

-- 
Enrico
**********************************
At this moment, the above is that I can do for this matter.

Tatsuro


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple