Web lists-archives.com

Re: Cygwin fails to utilize Unicode replacement character




On Sep  7 10:48, Brian Inglis wrote:
> On 2018-09-07 05:54, Corinna Vinschen wrote:
> > On Sep  7 13:51, Thomas Wolff wrote:
> >> On 07.09.2018 13:41, Thomas Wolff wrote:
> >>> On 07.09.2018 13:29, Corinna Vinschen wrote:
> >>>> On Sep  7 12:34, Thomas Wolff wrote:
> >>>>> On 07.09.2018 10:17, Corinna Vinschen wrote:
> >>>>>> On Sep  6 09:01, Corinna Vinschen wrote:
> >>>>>>> https://cygwin.com/ml/cygwin-cvs/2018-q3/msg00054.html
> >>>>>> I created new developer snapshots for testing.  Please give the latest fromhttps://cygwin.com/snapshots/  a try.
> >>>>> Raster Fonts: output of invalid encoding hangs cygwin...
> >>>>>> This will be my last action for the next 4 weeks though. I'll be
> >>>>>> back in October.
> >>>> Looks like s/ANSI_CHARSET/DEFAULT_CHARSET/ does the trick
> >>> Without this change, lf.lfFaceName is "T" when entering the do...while
> >>> loop.
> >> No, sorry, it's "Terminal" initially and then shortened down to "T" by one
> >> char each in the loop.
> >>> What's the purpose of this nested loop (do...while and EnumFontFamilies)
> >>> anyway?
> > The loop is handling the weird DejaVu Sans Mono behaviour I explained
> > in previous mail.
> 
> Garbage in font name from uninit struct on stack?
> Before call bzero/memset/implicit:
> 
> -  CONSOLE_FONT_INFOEX cfi;
> +  CONSOLE_FONT_INFOEX cfi = { 0 };

No, that doesn't help.  Do you really think I didn't try this?  Think
about it.  The string returned by GetCurrentConsoleFontEx is supposed to
be \0-terminated.  If the \0 follows *after* the stray characters, where
would they come from if not created by the GetCurrentConsoleFontEx
function itself?

> and remove loop, which opens an attack vector by renaming a good font
> and substituting one with a shorter name, or could cause problems by
> using the wrong font e.g DejaVu Sans.

How so?

> You need to self-impose a change freeze before heading out, once you're in
> "stuff to get done before leaving" mode, which may be a day or up to a week, you
> delegate or postpone decisions and actions until you return: BTDTGTS (Got The
> Scars) ;^>

I hear you.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: signature.asc
Description: PGP signature