Web lists-archives.com

Re: [bug: csih] Setting privileged rights to cyg_server fails on Windows 7.




Hi Csaba,

Thanks for your comment.

On Wed, 13 Jun 2018 16:39:22 +0200
Csaba Raduly  wrote:
> > --- cygwin-service-installation-helper.sh.orig  2015-10-28 18:23:35.000000000 +0900
> > +++ cygwin-service-installation-helper.sh       2018-06-13 22:24:30.353515600 +0900
> > @@ -2883,6 +2883,7 @@
> >      then
> >        # This test succeeds on domain member machines only, not on DCs.
> >        if [ "\\\\${COMPUTERNAME,,*}" != "${LOGONSERVER,,*}" \
> > +          -a "${LOGONSERVER}" != "" \
> >            -a "${LOGONSERVER}" != "\\\\MicrosoftAccount" ]
> >        then
> >         # Lowercase of USERDOMAIN
> >
> 
> Won't this break Windows 7 computers which *are* on a domain ?

I think it will not.

This if-statement judges whether the computer is on a domain or not.
The judgement should be true when it is on a domain.

Windows 7 computers on a domain set the environment LOGONSERVER.
So, added line results in true on them. Therefore, the judgment
result of the if-statement is the same as in the case without
the added line.

Windows 7 computer which is not on a domain does not set LOGONSERVER.
In this case:
"\\\\${COMPUTERNAME,,*}" != "${LOGONSERVER,,*}"  --> True
"${LOGONSERVER}" != "\\\\MicrosoftAccount"  --> True

So, the judgement without the added line is "It's on a domain.",
which is wrong. The added line avoids this miss judgement.

-- 
Takashi Yano <takashi.yano@xxxxxxxxxxx>

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple